[Libreoffice] [REVIEW] calc, spellchecking selection
kyoshida at novell.com
Wed Jun 15 07:31:52 PDT 2011
On Wed, 2011-06-15 at 10:51 +0100, Caolán McNamara wrote:
> So, looking at
> I see a bit of a nest of horrors around calc selections.
Welcome to (the horror of) Calc! :-) You'll find plenty of it around
here though I'm not sure how it compares to Writer.
> It's not massively clear to me how the calc selections are expected to
> work, but my thinking is that GetMarkData is an apparently reliable sane
> layer, and taking a FillRangeListWithMarks from that to use as the
> comparison that the selection has changed avoids the problem, and
> apparently works for me.
Yes. ScMarkData instance owned by ScViewData stores the authoritative
data on current range selection. So, you can certainly rely on that to
test for selection change, I would think.
> Thoughts ?, if no-one has a better view I'll take a punt and commit it
> in a few days to master.
I think your patch looks reasonable. I'm certainly not an expert of
this particular spell-checking code, but I don't see anything alarming.
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>
More information about the LibreOffice