[Libreoffice] Question about sal/qa/osl/process/osl_Thread.cxx

[Julien Nabet]

Hello,

Last "git version" of cppcheck says this :
[sal/qa/osl/process/osl_Thread.cxx:1099]: (warning) Redundant assignment 
of "sPrioStr" in switch
Here is the switch :
                 switch (_aPriority)
                 {
                 case osl_Thread_PriorityHighest:
                     sPrioStr = "Highest";
                     break;

                 case osl_Thread_PriorityAboveNormal:
                     sPrioStr = "AboveNormal";

                 case osl_Thread_PriorityNormal:
                     sPrioStr = "Normal";

                 case osl_Thread_PriorityBelowNormal:
                     sPrioStr = "BelowNormal";
                     break;

                 case osl_Thread_PriorityLowest:
                     sPrioStr = "Lowest";
                     break;
                 default:
                     sPrioStr = "unknown";
                 }

Do the break instructions lack for "AboveNormal" and "Normal" cases ?
If no, it could be better to have this :
                 // we want to have the same treatment for these 3 cases
                 case osl_Thread_PriorityAboveNormal:
                 case osl_Thread_PriorityNormal:
                 case osl_Thread_PriorityBelowNormal:
                     sPrioStr = "BelowNormal";
                     break;

Somebody to answer this ?

Julien.