[Libreoffice] [PATCH] Replace List with std::vector<>

Joseph Powers jpowers27 at cox.net
Sun Jun 19 21:48:39 PDT 2011

I'm sending the patch for review; not because it needs a lot but just to have someone verify that the memory was leaking and needs to be fixed.

Current fixes:
1. XPropertyList::Clear() looks like it has a memory leek; so I fixed it.

Future Fixes:
1.   List* pBmpList; Should be replaced with a std::vector< Bitmap*>
2. I thinking that once pBmpList is a vector<> I should cleanup the constructors that pass initial size and resize values.
3. I'm noticing that several methods have extra parameters that aren't used. Should I include a patch to clean them up also?

Joe P.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Replace-List-with-std-vector-XPropertyEntry.patch
Type: application/octet-stream
Size: 16213 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110619/0580ec3c/attachment-0001.obj>

More information about the LibreOffice mailing list