[Libreoffice] [PATCH] Replace List with std::vector<>
jpowers27 at cox.net
Sun Jun 19 21:48:39 PDT 2011
I'm sending the patch for review; not because it needs a lot but just to have someone verify that the memory was leaking and needs to be fixed.
1. XPropertyList::Clear() looks like it has a memory leek; so I fixed it.
1. List* pBmpList; Should be replaced with a std::vector< Bitmap*>
2. I thinking that once pBmpList is a vector<> I should cleanup the constructors that pass initial size and resize values.
3. I'm noticing that several methods have extra parameters that aren't used. Should I include a patch to clean them up also?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 16213 bytes
Desc: not available
More information about the LibreOffice