[Libreoffice] [PATCH] fix for fdo#37880: import of formulas with range names from xlsx fail

Markus Mohrhard markus.mohrhard at googlemail.com
Wed Jun 22 07:13:30 PDT 2011


Hi all,

I have fixed the problem behind fdo#37880 (fdo#38204 with similar symptoms
is not yet fixed). When we added local range names we forgot to adjust the
formula uno api(at least the global part of it). We need to save whether we
have a local range name or a global one. We lost this information when we
passed the information to the global part of the formula api and did not
gain them back when we converted them back to the local part of the formula
api.

I think that this is an important fix for 3.4.2 but we shouldn't push it to
the 3-4 branch before Kohei had a look at it. But I'd appreciate any
suggestions around this code before I push it to master.

Regards,
Markus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110622/906e1a19/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-for-fdo-37880_formula.patch
Type: text/x-patch
Size: 3103 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110622/906e1a19/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-for-fdo-37880_offapi.patch
Type: text/x-patch
Size: 3629 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110622/906e1a19/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-for-fdo-37880_sc.patch
Type: text/x-patch
Size: 2954 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110622/906e1a19/attachment-0005.bin>


More information about the LibreOffice mailing list