[Libreoffice] [GSoC][performance] patches for prefixing

[Matúš Kukan]

I'm sorry, forgot to send also to devlist.

On 25 June 2011 11:41, Matúš Kukan <matus.kukan at gmail.com> wrote:
> On 24 June 2011 16:08, Michael Meeks <michael.meeks at novell.com> wrote:
>>        Fun - perhaps there is a mapfile problem - whereby we are punching a
>> hole through the map file for the old component_getFactory name, and not
>> for the new foo_component_getFactory; at least I added a unit test to
>> cppuhelper and struggled with this for a bit myself ;-)
>>
> I really don't know what kind of problem there is.
> It seems to be alright, also we can call comphelp_component_ function.
> The only thing caused by diff in comphelper is that at the end of make check,
> soffice.bin does not end. It's running somewhere inside vcl. And
> CPPUNIT_ASSERT(desktop->terminate()); fails.
> I have no idea how that's related and how I could find the problem.
>
> I'm also sending cleaning diff for comphelper, maybe we could push that.
>
>>        Anyhow - I've merged your core patches, reverted the ABI break in
>> cppuhelper and done that another way (with a polymorphic impl. instead
>> of a default argument type). I attach a 'redo.diff' - this doesn't
>> really solve the problem I think, we need to add a 'prefix' parameter to
>> this framework macro so we can specify that as being different for each
>> component I think - can you hack that up ?
>>
> Sure, it was not good, so attached new diff for framework. (Maybe I
> could add parameter also to LOG_REGISTRATION_GETFACTORY ?)
> And also small change to dllcomponentloader in stoc is needed.
> And then if it's not too slow to call loadSharedLibComponentFactory
> through active() in factory.cxx we could also change that.
>
> Regards,
> Matus
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: comphelp.diff
Type: text/x-patch
Size: 1676 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110625/c0b4da5b/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: comphelper_cleaning.diff
Type: text/x-patch
Size: 12009 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110625/c0b4da5b/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: framework.diff
Type: text/x-patch
Size: 8110 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110625/c0b4da5b/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dllcomponentloader.diff
Type: text/x-patch
Size: 821 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110625/c0b4da5b/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: factory.diff
Type: text/x-patch
Size: 2170 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110625/c0b4da5b/attachment-0009.bin>