[Libreoffice] [PATCH] impress: after adding a new animation, scroll down to it in the list.

Luke Symes allsymes at gmail.com
Sun Jun 26 03:27:51 PDT 2011

Hi Radek,

On Sat, Jun 25, 2011 at 3:35 AM, Radek Doulik <rodo at novell.com> wrote:
> At least I am not reaching the part you modified when adding custom
> animation thru custom animation pane (using the add button and custom
> animation dialog). If we move it to the loop, it will be reached always
> when selecting an entry - the select method is called recursively when
> adding new pEntry in:
>    if( !pEntry && bSelect )
>    {
>        append( pEffect );
>        select( pEffect );
>    }
> I wonder how do you reach that part of code?

Hmm. I think the code is incorrect here. That last if statement should
really only be used if the effect wasn't in the list & needs to be added.
But when I added the MakeVisible in the if statement, it made new animations
be scrolled to, and I was doing it via add->custom animation dialog too.
What do you think of my attached patch? Once we have found the given entry,
we should select it and then we are done, aren't we?

Kind regards,

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110626/aa59e58c/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Scroll-to-newly-added-animations-in-the-list.patch
Type: text/x-patch
Size: 1165 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110626/aa59e58c/attachment.bin>

More information about the LibreOffice mailing list