[Libreoffice] [PATCH][PUSHED] impress: after adding a new animation, scroll down to it in the list.

Luke Symes allsymes at gmail.com
Mon Jun 27 01:57:06 PDT 2011


2011/6/27 Radek Doulík <rodo at novell.com>

> Hi Luke,
>
> > @@ -542,6 +543,7 @@ void
> > CustomAnimationList::select( CustomAnimationEffectPtr pEffect, bool
> > bSelect
> >      {
> >          append( pEffect );
> >          select( pEffect );
> > +        MakeVisible( Last() );
>
> we don't need to call it here ^^^, as select( pEffect ); on the previous
> line recursively calls this function again and it is made visible from
> the loop above already. So it should be enough to add it to the loop.
>

Ah yes, of course!

I have updated your patch and pushed it.


Thanks very much :)

>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110627/12d37d92/attachment.htm>


More information about the LibreOffice mailing list