[Libreoffice] [PATCH] [PUSHED] One bool mistake in msfilter

Kohei Yoshida kohei.yoshida at gmail.com
Sat Mar 5 12:02:12 PST 2011

Hi Arnaud,

On Fri, Mar 4, 2011 at 7:17 AM, Arnaud Versini <arnaud.versini at gmail.com> wrote:
> Hello,
> This verry small patch replace BOOL by bool for bRetValue.

Thanks. Pushed to master.

> Can I replace all BOOL from msfilter to bool?

Sure, why not.  But please don't do a blind replacement of all BOOL's
to bool, and at least check each case to make sure that BOOL is used
truly as a boolean value.  Sometimes some people abused the fact that
BOOL was a typedef to char, and used it as an integer, in which case
we should replace it by an integer type not bool.


More information about the LibreOffice mailing list