[Libreoffice] [PATCH][PUSHED] In download.in file, use 3.3.1 as LibreOffice regexp value to correctly get tarballs.

Petr Mladek pmladek at suse.cz
Wed Mar 9 07:47:05 PST 2011


Petr Mladek píše v Po 14. 02. 2011 v 16:10 +0100:
> Gökçen Eraslan píše v Po 14. 02. 2011 v 15:29 +0000:
> > Pazartesi 14 Şubat 2011 günü (saat 13:16:01) Petr Mladek şunları yazmıştı:
> > > Gökçen Eraslan píše v Pá 11. 02. 2011 v 15:58 +0000:
> > > > This patch makes ./download command in LibreOffice 3.3.1.0 work with
> > > > --without-git option.
> > > 
> > > Thanks a lot for the fix. I have pushed it into the libreoffice-3-3 and
> > > libreoffice-3-3-1 branches.
> > >
> > 
> > Are you sure about committing libreoffice-3-3 branch? Because patch changes 
> > 3\.3\.0 to 3\.3\.1, not just adds 3\.3\.1.
> 
> I wanted to keep it in sync. In fact, the libreoffice-3-3 branch is
> going to be for the libreoffice-3.3.2 sources.
> 
> >  Maybe we must change regexp to 
> > "libreoffice-.*-3\.3.*" and use both in 3.3 and 3.3.1 branches?
> 
> Great idea. Could you please review the attached patch?

Ah, it seems that we both have forgot about this, so it is broken in
LO-3.3.2.1 again.

I have just pushed the universal fix to both libreoffice-3-3 and
libreoffice-3-3-2 branches:
http://cgit.freedesktop.org/libreoffice/build/commit/?h=libreoffice-3-3&id=91fb8e498a4104ed1cbce4e499def3e7e42a6e63
http://cgit.freedesktop.org/libreoffice/build/commit/?h=libreoffice-3-3-2&id=45b9b1420495daa5e698fff53f14d4bcacd02e8b

Best Regards,
Petr



More information about the LibreOffice mailing list