[Libreoffice] [PATCH] Remove most of dead code in libs-core

Christina Roßmanith ChrRossmanith at web.de
Thu Mar 10 02:11:14 PST 2011


Hi,

I'm having a look at your patch files. The first thing to mention is 
that "whitespace-only changes" should be avoided. The second thing: 
12000 lines for a single patch file is too long. You should split them 
into pieces that reviewing a single patch can be done in a reasonable time.

You'll have to be very patient until everything is reviewed. I'll skip 
"whitespace only" only changes.

Christina Rossmanith

Am 08.03.2011 21:06, schrieb Xisco Faulí:
> Hello,
>
> I've been working on removing dead code in libs-core for a while ago. 
> I'd say libs-core it's now 98-99% dead code free. I built all the 
> modules I worked in, and everything is allright.
> I tried to attach the patches into a previous email but it was too big 
> so the mailing list refused it. I copy a rar file with 25 patches in 
> my dropbox: http://dl.dropbox.com/u/1274885/remove-dead-code.zip . I 
> swear it's 100% virus free.
>
> Cheers
>
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110310/8890aded/attachment.htm>


More information about the LibreOffice mailing list