[Libreoffice] [PATCH] Comment cleanup writer
Muthu Subramanian K
sumuthu at novell.com
Thu Mar 10 03:38:38 PST 2011
I am assuming you are working on an improved version of the patch taking
Cedric comments into consideration.
Thank you so much for your contributions! Looking forward for more...
- Muthu Subramanian
On 03/08/2011 02:21 PM, Cedric Bosdonnat wrote:
> Hi Muthu, David,
> On Mon, 2011-03-07 at 21:46 +0530, Muthu Subramanian K wrote:
>> Hi David,
>> Thank you for you patch.
>> The general rule is to keep the "i####" kind of numbers - these are
>> issuezilla ids. But, in this case I would prefer to go with you to
>> remove most of these - since, in this patch context, the ids seem to
>> have been added to every line.
>> On the other hand, I would prefer another person reviewing before I push
>> these changes - cedric?
> I would keep the #i91601# before one FN_UNO_LIST_ID to show it has been
> added to fix that bug, but remove the other instances. IMHO quite a lot
> of #i123456# comments would be lost: these need to be kept in at least
> some strategic places.
More information about the LibreOffice