[Libreoffice] [PATCH] [PUSHING] translate german comments in /sc/inc

Tor Lillqvist tlillqvist at novell.com
Fri Mar 11 00:15:07 PST 2011


> Patch 4 only removes structuring 
> "//-----------------------" lines. I'm not sure if this is wanted. Maybe 
> someone of the experts can comment on this? 

I would say yes, definitely. Vertical space is a non-renewable resource, as I think Michael so nicely put it.

Such comments have no value if used between more or less all methods in a source file.

Removing them should be done exactly as you say, in a diff / patch by itself that does nothing else, so that it is trivial to confirm that it indeed does nothing else.

They have value if they (or similar comments) if given some semantic meaning, for instance if used to indicate parts of a source file that are differently licensed, cop-pasted from some other source, or something like that. Of course, in such a case only if accompanied by a textual explanation. Like "// ----- From here to the next // ----- the code is copied from libfoo version 4.2 which is licensed under a MIT/X11 license."

--tml




More information about the LibreOffice mailing list