[Libreoffice] Rewiew needed for pythonscript.py patch (new try)

Caolán McNamara caolanm at redhat.com
Mon Mar 14 05:36:16 PDT 2011


On Sat, 2011-03-12 at 23:43 +0100, Julien Nabet wrote:
> And now, ladies and gentlemen, the patch !  :-)

Why the addition of a "uri = expandUri( name )" into replaceByName ?,
i.e. this hunk

@@ -962,8 +964,9 @@ class PythonScriptProvider( unohelper.Base,
XBrowseNode, XScriptProvider, XNameC
 
     def replaceByName( self, name, value ):
...
-        removeByName( name )
-        insertByName( name )
+        uri = expandUri( name )
+        self.removeByName( name )
+        self.insertByName( name, value )
...

C.



More information about the LibreOffice mailing list