[Libreoffice] Rewiew needed for pythonscript.py patch (new try)
kendy at suse.cz
Thu Mar 17 03:41:01 PDT 2011
On 2011-03-14 at 13:20 +0000, Caolán McNamara wrote:
> > I added this because of a warning (error) with pychecker. On the
> > contrary of the other blocks, the variable uri "wasn't" declared and
> > initialized whereas it was used in this block.
> Ah, i see it now, its a use of that "uri" inside the log.debug line.
> Indeed, if logging was turned on then replaceByName would fail due to a
> missing uri, so its a good fix after all
Seems to me that there are no objections [and for me after a brief look
looks good too], so please go ahead, and push :-)
More information about the LibreOffice