[Libreoffice] [REVIEWED] Review requests for mailmerge to email fixes

Michael Meeks michael.meeks at novell.com
Fri Mar 18 10:12:29 PDT 2011


	Thanks so much for that Caolan ! :-)

On Fri, 2011-03-18 at 17:56 +0100, Petr Mladek wrote:
> > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=7482695994c5f6bf9995748944e38d2792aaed92

	This took quite some reading ... you essentially achieve:

	nNodeCnt = max(1, nNodeCnt - nDistance);

	right ? but it looks great, nice to have a complete fix.

> > Secondly, sending an email with an attached .odt. We're looking up the
> > epic fail. Simplest fix is to pull the known export filter directly
> > rather than hope for the best off ".odt"
> > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=5c4a455137ae1fc74cdf88fe6d4d315b1948b4c0

	Great catch too :-)	

> > Thirdly, send an email with an attached .pdf won't work unless mailmerge
> > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=97bce7aad1c3a6f3fd23a3380c79ca9c1515624c

	And also fine.

> We still need 2 more reviews for the libreoffice-3-3 branch.

	You have one from me, thanks again !



 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list