[Libreoffice] [REVIEW] Re: [PATCH] Review requests for mailmerge to email fixes

Jan Holesovsky kendy at suse.cz
Fri Mar 18 17:54:04 PDT 2011

Hi Petr,

On 2011-03-18 at 17:56 +0100, Petr Mladek wrote:

> > and I'd like backport three concrete and fairly trivial fixes which
> > address the reproducible parts to 3-3-2

Caolán - thank you for that!

> > Firstly, the hang.
> > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=7482695994c5f6bf9995748944e38d2792aaed92
> Looks fine. I have cherry-picked it for libreoffice-3-3 branch as 
> http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-3&id=d1234b1bcd542b4ce523b6be76e7491afdce4de8

Looks good to me too.

> > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=5c4a455137ae1fc74cdf88fe6d4d315b1948b4c0
> > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=97bce7aad1c3a6f3fd23a3380c79ca9c1515624c
> Caolan, could you please review the attached patch? You might see that
> there was an attempt to solve this but it did nothing. It compiles and
> works here.

Looks good too.

> We still need 2 more reviews for the libreoffice-3-3 branch.

You have mine ;-)


More information about the LibreOffice mailing list