[Libreoffice] [REVIEWED] Review requests for mailmerge to email fixes
caolanm at redhat.com
Mon Mar 21 02:03:26 PDT 2011
On Fri, 2011-03-18 at 18:48 +0100, Petr Mladek wrote:
> Michael Meeks píše v Pá 18. 03. 2011 v 17:12 +0000:
> > On Fri, 2011-03-18 at 17:56 +0100, Petr Mladek wrote:
> > > > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=7482695994c5f6bf9995748944e38d2792aaed92
> > This took quite some reading ... you essentially achieve:
> > nNodeCnt = max(1, nNodeCnt - nDistance);
> Does this really work when both nNodeCnt and nDistance are unsigned
> long? It might produce a huge number if (nNodeCnt < nDistance).
That's not the real code above, that's the pseudo-code. The pseudo-code
would indeed wrap around to a huge number given that we're working in
unsigned values, but the real code avoids that.
More information about the LibreOffice