[Libreoffice] [PATCH] [WIP] Remove most of dead code in libs-core

Christina Roßmanith ChrRossmanith at web.de
Mon Mar 21 05:02:23 PDT 2011


Am 20.03.2011 00:52, schrieb Xisco Faulí:
> Here we go with the first round of patches.
> Whitespaces are not deleted anymore and all the bogus have been 
> deleted. Everything builds allright.
> Part 1 --> 
> http://dl.dropbox.com/u/1274885/removed-commented-code-part1.tar.gz
> I'll post the second part soon
>
> Greetings
>
Hi,

I've applied the first part of your new patch set (basic). Additionally 
I've removed some surrounding {} after a commented if () was removed. 
The indented block has been "unindented", hope that is ok though it's a 
"whitespace only"-change. Otherwise it looks a little strange...

If you remove bugids which are embedded into a sentence make sure the 
sentence is complete without the bugid or leave it to someone who 
translates the comment (if it's still German) and changes the sentence 
during translation in a way that it is still useful without the bugid.

In the meantime there were many BOOL changed to sal_Bool which makes 
applying the patches a little more work. But I'll continue as time permits.

Thank you for your work!

Christina


More information about the LibreOffice mailing list