[Libreoffice] [PUSHED] Re: [PATCH] fix obvious bug in VCL that prevent glyph-fallback for one glyph-missing character at the end of string
caolanm at redhat.com
Thu Mar 24 08:30:45 PDT 2011
On Thu, 2011-03-24 at 21:27 +0700, Samphan Raruenrom wrote:
> While working on other bugs, we found this bug in
> vcl/win/source/gdi/salgdi3.cxx b/vcl/win/source/gdi/salgdi3.cxx . When
> there is only one character at the end of the string that require
> glyph-fallback, the bug prevent glyph-fallbacking. Because the code
> will not detect that the last character need glyph-fallback. It is an
> obvious bug because of wrong loop's terminating condition checking.
> Please take a look.
Looks good to me, makes sense. Pushed now, thanks for this.
More information about the LibreOffice