[Libreoffice] [PATCH] fdo#34908

[Noel Power]

Hi All,
I have a patch ( well really this is a workaround ) for a strange issue 
( https://bugs.freedesktop.org/show_bug.cgi?id=34908 ) that I have been 
looking at on and off for the last while.
Briefly what is happening is that a dynamic_cast is failing in the 
distro build ( e.g. with patches ) but only on 32 bit, the corresponding 
rawbuild build works as expected. On 64, both distro and non distro 
builds behave as expected ( no problems in this area )

Note: nm -C | grep  CheckboxMark on the various libraries yields afaics 
mostly identical results, another test I did was to build the sw module 
from the rawbuild tree in the distro tree, running with those libraries 
yields the same problem ( confirming what I already thought from lots of 
manual patch reverts ) but interestingly moving those same libraries 
into the the rawbuild install and they work again :-/

Anyway the patch/workaround is here 
https://bugs.freedesktop.org/attachment.cgi?id=44788

In addition to review it would be great to get some opinion on what is 
the best way to deliver this fix, myself and Petr couldn't quite decide 
which was the best option, the choices are
   a) leave this as a patch ( with some note in apply ) at least we wont 
forget about the problem
   b) commit directly into the branch, this sortof sweeps the problem 
under the carpet ( which make me a little uncomfortable )

Noel