[Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer
michael.meeks at novell.com
Fri Mar 25 13:48:25 PDT 2011
On Thu, 2011-03-24 at 12:17 +0100, Miklos Vajna wrote:
> I'm attaching two patches, one for vcl, one for sw. Of course I could
> introduce the define in sw, but that would cause problems when someone
> would introduce a new define in vcl, so I did it this way.
Looks lovely to me - though I guess it might be nice to just pick a
large number for RET_APPLY and not put that in vcl; that seems to be
how others do it eg.
sfx2/inc/docvor.hxx:#define RET_EDIT_STYLE 100
sfx2/inc/sfx2/new.hxx:#define RET_TEMPLATE_LOAD 100
etc. if we want to clean this up - we should add a:
#define RET_CUSTOM_START 100
or something, to the vcl header, and then use that (I think)
> Also, I can change the indentation in sw/source/ui/app/docst.cxx, I
> didn't do it yet for easier review.
> What's your opinion, OK to push?
With the above tweak I'm enthusiastic - nice patch ! :-) but ... why
are you (Mr Awesome) doing 'easy' hacks ? :-) I guess for each one you
fix, you need to research & create one more ;->
michael.meeks at novell.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice