[Libreoffice] [PATCH] Export of docs with images/charts into xlsx (possibly pptx)
Katarina Machalkova
kmachalkova at suse.cz
Tue May 3 23:42:50 PDT 2011
Hey there,
can some1 please review the attached patch for 3.4? Export of xlsx docs
containing images or charts (GraphicObjectShape) fails with generic "cannot
write" error (there is no particular bug id. associated with the issue so far
... but I didn't search fdo bugzilla so well)
The problematic code is introduced by commit b49d4405f4a8919. I haven't even
remote clue what is it supposed (not) to be doing, more specifically why an
attempt to retrieve value of non-existing property
('Is[Empty]PresentationObject') throws an exception and/or why the object in
question doesn't have the mentioned property. There is handful of places where
property value is being retrieved without prior checking all over the code.
Anyway, the patch seems to do the job (the spreadsheet with imgs is saved as
xlsx) and moreover, a similar trick is used in xmloff module
(source/draw/shapeexport2.cxx, XMLShapeExport::ImpExportPresentationAttribute
method)
Thx
B.
--
\\\\\ Katarina Machalkova
\\\\\\\__o LibO developer
__\\\\\\\'/_ & hedgehog painter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: picxlsxexport.diff
Type: text/x-patch
Size: 2876 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110504/47c4a21b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110504/47c4a21b/attachment-0001.pgp>
More information about the LibreOffice
mailing list