[Libreoffice] [PUSHED] Re: [PATCH] new color picker dialog for all applications

Jan Holesovsky kendy at suse.cz
Fri May 6 07:18:09 PDT 2011

Hi Christian,

On 2011-05-05 at 22:18 +0200, Christian Lippka wrote:

> It replaces the old color picker with a new one. See here for a video
> demo
> http://youtu.be/rPu6EmIxkIM?hd=1
> To see it in the running office you can for example go to menu
> tools->options->colors and press edit

Beautiful! :-)  Thanks for the great work!

> http://dl.dropbox.com/u/10629960/patch.txt
> The patch is against an OOo DEV300 m102, so there may be conflicts.
> There is one binary included in the patch, which looks like a git
> patch can handle. If not, here is the image

I've cleaned it up a bit to fit master - cui has been gbuildized, I've
changed the tabs to 4 spaces, added the vim / emacs modelines, fixed a
duplicate in colorpicker.hrc, and made the wrong input of hex not
beeping; all just nitpicking :-)

The biggest change I did was:


We should not introduce duplicate functions when we already have them in
a library (basegfx in this case).  Additionally, from some reason the
'equals()' function was evaluating incorrectly, no idea why - probably
some difference between stlport and std; but I did not investigate
further, as it is gone anyway :-)  Would be great to move the rgb <->
cmyk methods to basegfx at some stage too.

All in all - great stuff, thank you a lot for that, and looking forward
to your next patch! :-)

All the best,

More information about the LibreOffice mailing list