[Libreoffice] testDataPilot unit test breaks in sc

[Thorsten Behrens]

Kohei Yoshida wrote:
> > This unit test expects that the UI is in English. Two English strings
> > are hard coded into this test: Sum and Total.
> 
> So, I looked into this this morning in hopes of finding a way to set UI
> locale to en-US explicitly.
> 
> http://cgit.freedesktop.org/libreoffice/calc/commit/?h=libreoffice-3-4&id=5051d6a1f1e239fb38c60a227046111ec438a518
> 
> But at the moment this causes run-time exception.  I haven't
> investigated deeper into this to find out why.
> 
Hi,

so, finally got to the bottom of this - patches attached. I feel
*slightly* worried about pushing
0001-Fix-non-changeability-of-UI-locale.patch to -3-4 - the second
hunk has some potential to cause loops, so review appreciated.

Generally, and going forward - I'd be a bit happier if unit tests
would not assume en-US locale at all, since at least in theory, it's
possible to do a build w/o en-US at all...

Cheers,

-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Force-calc-unit-test-to-use-en-US-locale-and-strings.patch
Type: text/x-patch
Size: 3044 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110506/6204078c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-non-changeability-of-UI-locale.patch
Type: text/x-patch
Size: 2444 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110506/6204078c/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110506/6204078c/attachment.pgp>