[Libreoffice] Moving duplicate code into methods
Chr. Rossmanith
ChrRossmanith at gmx.de
Sat May 7 13:54:40 PDT 2011
Hi,
I've used the method names Thorsten suggested, prefixed them with lcl_
made them static and end up with two commits for the whole clean up
(stage 1 posted on the list, stage 2 improvements). Is that ok for
pushing or should I somehow join the two commits into a single one?
Christina
Am 03.05.2011 09:24, schrieb Thorsten Behrens:
> Chr. Rossmanith wrote:
>> I've found two duplicate code with simian and moved it into two new
>> methods which saves 229 lines of code. It would be nice if someone
>> could review the patch and at least suggest better names for the
>> methods...
>>
>
More information about the LibreOffice
mailing list