[Libreoffice] lotuswordpro again/still.... DeInitVCL in cppunit tests correct?

Christian Lohmaier lohmaier+libreoffice at googlemail.com
Sat May 7 17:24:50 PDT 2011

Hi *,

trying to find the cause of the breaker on Mac / PPC I'm also looking
at commit history (without much luck, as apparently before
gbuildifying the module and enabling the checks there, the checks
weren't run at all, thus I guess it failed from the very
beginning/never worked)...

commit c4a0b38fb0bbd86e4c6d1abc034e63c98d6ab475
Author: David Tardon <dtardon at redhat.com>
Date:   Wed Apr 27 10:31:31 2011 +0200

    clean up

diff --git a/lotuswordpro/qa/cppunit/test_lotuswordpro.cxx
index 29f7d6e..bb481bd 100644
--- a/lotuswordpro/qa/cppunit/test_lotuswordpro.cxx
+++ b/lotuswordpro/qa/cppunit/test_lotuswordpro.cxx
@@ -48,6 +48,7 @@ namespace
+        ~LotusWordProTest();

         virtual void setUp();
         virtual void tearDown();
@@ -90,6 +91,11 @@ namespace

+    LotusWordProTest::~LotusWordProTest()
+    {
+        DeInitVCL();
+    }
     void LotusWordProTest::setUp()

introduces additional warning/error spew to the existing cppunit failure:
Test name: (anonymous namespace)::LotusWordProTest::test
assertion failed
- Expression: bRes == bExpected
- file:///Users/buildslave/compile/libreoffice/clone/filters/lotuswordpro/qa/cp

Failures !!!
Run: 1   Failure total: 1   Failures: 1   Errors: 0
2011-05-08 02:16:37.703 cppunittester[3545] ***
_NSAutoreleaseNoPool(): Object 0x4281f0 of class
RemoteControlContainer autoreleased with no pool in place - just
2011-05-08 02:16:37.703 cppunittester[3545] ***
_NSAutoreleaseNoPool(): Object 0x4280d0 of class
MultiClickRemoteBehavior autoreleased with no pool in place - just
make: *** [/Users/buildslave/compile/libreoffice/solver/300/unxmacxp.pro/workdir/CppunitTest/lotuswordpro_test_lotuswordpro.test]
Error 1

the "no pool in place - just leaking" (according to
http://openoffice.org/bugzilla/show_bug.cgi?id=113170 ) is caused by
using vcl-function outside of the main-loop - so I wonder whether the
above change is correct. I'm not understanding it all well enough to
judge myself, but deinitializing vcl while requiring the main-loop
sounds related enough...

But "cleanup" as commit message just doesn't tell anything to me...


More information about the LibreOffice mailing list