[Libreoffice] [LibreOffice][PATCH]EasyHack: Replace DBG_ macros with OSL_ equivalents

Christian Lohmaier lohmaier+libreoffice at googlemail.com
Mon May 9 03:13:15 PDT 2011


HI * -

your mail has been flagged as spam by gmail, so I reply to unhide it
for other gmail users/ping them to look in the spam folder to recover
it :-)

Thanks for the patches! :-)

On Sun, May 8, 2011 at 11:27 PM, Jacek Wolszczak
<shutdownrunner at gmail.com> wrote:
>
> Attached hereto are two patches. The first one replaces DBG_WARNING,
> DBG_ASSERT, etc. with OSL_ASSERT and OSL_FAIL in writer/sw directory.
>
> I have also removed writer/sw/source/core/inc/dbgloop.hxx as it's not
> used anywhere (patch 2).
>
> In
> http://opengrok.libreoffice.org/xref/writer/sw/source/core/access/acccontext.cxx#1520
>
> TEST_MIB is never defined so I guess that DBG_MSG could be removed as
> there are probably better ways to debug accessibility stuff.

Yes, indeed, this very, very likely is a leftover from an individual
developer's working-tree (MIB is a developer's id)


> In the case of http://goo.gl/D0nC8. Do you think that dbgoutsw.* could
> be removed and dbg_out be either removed from ww8/* files or replaced
> with some other debug function?

Please put other question in a seperate thread - it makes tracking the
patches (have they been integrated already?) and also answereing the
other questions much easier.

> Everything is LGPL3 / MPL if you find it useful.

Of course, but make that the "+" variant please :-)

ciao
Christian


More information about the LibreOffice mailing list