[Libreoffice] [REVIEW] Proper initialization and copying of union matrix value.

Kohei Yoshida kohei.yoshida at gmail.com
Thu May 12 19:10:16 PDT 2011


I'd like to commit the attached patch to the 3.4 branch.  This was
discovered by the unit test which failed when an empty matrix element
didn't have a value of 0.0.  As it turned out, I was initializing the
higher 4 bytes via 32-bit pointer but the lower 4 bytes were left
un-initialized, which caused the double value to become non-zero.
Apparently this doesn't happen when building a 64-bit build.

Thanks,

Kohei
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Properly-initialize-and-copy-fVal.patch
Type: application/octet-stream
Size: 1944 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110512/3d39623c/attachment.obj>


More information about the LibreOffice mailing list