[Libreoffice] [REVIEW] Fix crash when importing doc from fdo#36239
michael.meeks at novell.com
Thu May 19 04:21:09 PDT 2011
On Thu, 2011-05-19 at 12:44 +0200, Cedric Bosdonnat wrote:
> could you please review / push this patch to 3.4 and 3.4.0? It's a
> simple fix that would save quite some crashes.
Looks fine to me - of course I'd prefer:
- xub_StrLen nEndPos = rEnd == rStart ? rEnd.nContent.GetIndex() : rEnd.nContent.GetIndex() - 1;
+ xub_StrLen nEndPos = MAX (0, rEnd.nContent.GetIndex() - 1);
which looks like it might do the same thing ? ;-)
But - you have my review ...
michael.meeks at novell.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice