[Libreoffice] [Patch] [PUSHED] [REVIEW REQUEST] Hover over icons produces the wrong behavior

Michael Meeks michael.meeks at novell.com
Fri May 20 03:15:11 PDT 2011


On Fri, 2011-05-20 at 03:17 -0600, Tor Lillqvist wrote:
> --- a/vcl/source/window/toolbox.cxx
> +++ b/vcl/source/window/toolbox.cxx
> @@ -3494,7 +3494,8 @@ void ToolBox::ImplDrawItem( sal_uInt16 nPos, sal_Bool bHighlight, sal_Bool bPain
>      MetricVector* pVector = bLayout ? &mpData->m_pLayoutData->m_aUnicodeBoundRects : NULL;
>      String* pDisplayText = bLayout ? &mpData->m_pLayoutData->m_aDisplayText : NULL;
>      
> -    bHighlight = bHighlight && pItem->mbEnabled;
> +    if(!pItem->mbEnabled)
> +        bHighlight = 0;

	Looks fine to me. We should of course try to fix it in a pleasant way
on master ;-) and I love that:

        bHighlight = 2;

	goodness ;-)

	Thanks !

		Michael.

-- 
 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot




More information about the LibreOffice mailing list