[Libreoffice] Review request: fix for crash fdo#36495
kyoshida at novell.com
Fri May 20 09:33:44 PDT 2011
On Fri, 2011-05-20 at 12:11 -0400, Kohei Yoshida wrote:
> On Fri, 2011-05-20 at 07:48 -0600, Tor Lillqvist wrote:
> > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=37b8567fc76b78b1844461926175ba6919b8c7bd
> > Not marked as a mostly annoying bug, but it is a crasher, so perhaps
> > should be cherry-picked to the -3-4 or even -3-4-0 branches?
Despite my comment, this method seems to boldly access vector elements
by index without checking its size all over the place, so maybe the
index value is already checked beforehand?
Anyway, I'm sure this is safer as-is. Pushed to the -3-4-0 branch.
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>
More information about the LibreOffice