[Libreoffice] [REVIEW] fdo#35728 Fix crash from forms.OGridControlModel unoapitests

[Bjoern Michaelsen]

On Mon, 23 May 2011 11:51:59 +0200
Bjoern Michaelsen
<bjoern.michaelsen at canonical.com> wrote:

> Hi all,
> 
> please review: 
> http://cgit.freedesktop.org/libreoffice/components/commit/?id=19ed36590e990b5281da9c54bd962031bd56ae82
> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=f25b836319678ab333a1a997cc7fdadfedad8e08
> 
> * various forms.OGridControlModel tests segfaulted
> * root cause is the migration to stl containers in DbGridControl
> * the old tools container returned the removed pointer or NULL causing
>   no failure
> * a signed int was used as index while the functions returned a
>   unsigned int
> * the GRID_COLUMN_NOT_FOUND magic value was out of the signed range
> 
> for both 3-4 and 3-4-0 branches.

forgot to add: this is
https://bugs.freedesktop.org/show_bug.cgi?id=35728

Best,

Bjoern

-- 
https://launchpad.net/~bjoern-michaelsen