[Libreoffice] [REVIEW] Complete fix for fdo#32684
michael.meeks at novell.com
Mon May 23 04:20:35 PDT 2011
On Mon, 2011-05-23 at 12:55 +0200, Cedric Bosdonnat wrote:
> That bug was badly fixed (by me) quite some times ago. Here is a
> correct fix (why did I add that code at all ?). Could you review it
> and push it in 3.4 and 3.4.0?
> More cleanup is needed but it'll end up in master: some options aren't
> used at all in that area.
So - its hard to see quite what problem it causes; but:
> - sal_Bool bCJKEnabled = aCJKOptions.IsAsianTypographyEnabled();
> - bApplyCharUnit = bCJKEnabled;
> - eHScrollMetric = bApplyCharUnit ? FUNIT_CHAR : eUserMetric;
> - eVScrollMetric = bApplyCharUnit ? FUNIT_LINE : eUserMetric;
Surely leaving un-initialized members lying around in the instance is
worse than initializing them to wrong values ? How dangerous are the
wrong values if they are not used ?
michael.meeks at novell.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice