[Libreoffice] [REVIEW] fdo#35345: more Calc (auto)filter evilness

Markus Mohrhard markus.mohrhard at googlemail.com
Tue May 24 08:50:24 PDT 2011

Hello Katarina,

the idea is good, but I think we should move this code to
ScDocument::GetFilterDBAtTable because I'm not quite sure if there are not
some cases where there is a sheet local db data but no dbcollection. I
personally would prefer that but I'm fine with this patch too.

Sol you've my sign of.

Regards, Markus


2011/5/24 Katarina Machalkova <kmachalkova at suse.cz>

> Ladies & gentlemen,
> attached is the patch with (hopefully the final) fix for $subject. I'd like
> to
> push it to 3-4 and considering the fact that some data loss is involved,
> prolly also to 3-4-0 although I'm not entirely positive about that.
> The orig. patch from IBM Symphony folks took just some scenarios into
> account
> and happily kept deleting cell data in drag-fill operation in all other
> cases
> (as described here: https://bugs.freedesktop.org/show_bug.cgi?id=35345#c10
> )
> Now we're trying to look also for anonymous DB data in the current sheet
> and
> check those for the presence of autofilter or query params.
> Please review & comment. /me doesn't know this particular pieces of code so
> well.
> frozenB.
> --
>  \\\\\              Katarina Machalkova
>  \\\\\\\__o          LibO developer
> __\\\\\\\'/_          & hedgehog painter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110524/4c55d4f4/attachment-0001.htm>

More information about the LibreOffice mailing list