[Libreoffice] [REVIEW] Fix for fdo#37520

Markus Mohrhard markus.mohrhard at googlemail.com
Tue May 24 14:03:16 PDT 2011

You have my sign off and pushed to 3-4.

2011/5/24 Kohei Yoshida <kohei.yoshida at gmail.com>

> The attached patch fixes the crasher reported in
> https://bugs.freedesktop.org/show_bug.cgi?id=37520
> The crash occurs in ScRangeList::Join() where the array size is cached
> prior to the for loop, but array may shrink during the loop, in which
> case an out-of-bound array access may occur which in turn results in a
> crash.  I'm actually surprised that this didn't cause a crash on
> Linux.
> Anyhow, the solution is to always dynamically check the size of the
> array via size() method in each iteration, instead of caching it for
> all iterations.
> Review appreciated.  I'd like this to go into the -3-4-0 branch.  So I
> need three sign-off's.
> Kohei
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110524/b4da2d80/attachment.htm>

More information about the LibreOffice mailing list