[Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one

Cedric Bosdonnat cedric.bosdonnat.ooo at free.fr
Fri May 27 07:03:45 PDT 2011

Hello Markus,

On Fri, 2011-05-27 at 14:02 +0200, Markus Mohrhard wrote:
> yes there might still be some problems, I only tried to fix that
> during pasting to calc all borders are drawn. I'm not familiar with
> the RTF spec and the old code(before Cedric refactored it) was really
> ugly and even used some gotos.
> This quick patch was more or less a result of
> https://bugs.freedesktop.org/show_bug.cgi?id=37429 as I noticed that
> borders were totally screwed up. If I can help in any way just mail me
> and I have a look at it.

I pushed your patch with the {} block for the Ifs to keep the previous
way things were working... though I'm not sure if they make sense at

There are still some things to improve there as I mentioned. I won't
have time to fix them now, so feel free to fix them if you like. Among
those things to fix / check:
  * is the bTableDef still needed?
  * fix the border widths as they're not all pasted.

Thanks again for your patch, and sorry for the delay to integrate your

Cédric Bosdonnat
LibreOffice hacker
OOo Eclipse Integration developer

More information about the LibreOffice mailing list