[Libreoffice] [PATCH] Duplicate code: join ImportFrom and InsertFrom

Chr. Rossmanith ChrRossmanith at gmx.de
Tue May 31 05:03:59 PDT 2011


more duplicate code cleanup.

Class SfxObjectShell has two nearly identical methods: ImportFrom and 
InsertFrom. The latter has a few lines of code more, so I've removed 
InsertFrom (which was added to the code base later than ImportFrom), 
added a boolean parameter to ImportFrom and adjusted the few calls to 
those methods. And InsertFrom is not virtual like ImportFrom. Please 
review the attached patches. I'll commit them if I get an "ok".

The changes affect three modules (libs-core/sfx2, writer/sw and impress/sd).


More information about the LibreOffice mailing list