[Libreoffice] Warning in basic/source/runtime/runtime.cxx

Michael Meeks michael.meeks at novell.com
Tue May 31 06:18:27 PDT 2011


On Tue, 2011-05-31 at 11:58 +0200, David Tardon wrote:
> On Tue, May 31, 2011 at 10:27:19AM +0100, Michael Meeks wrote:
> > +            PTR_CAST(BasicCollection,pVar) == pCollection )
> > 
> > 	I'll commit that, and wait for screams.
> 
> Moreover, I think there should be p = p->pNext at the end of the loop.
> Otherwise we either hit the right collection at first try or we are
> cycling until the heat death of the Universe .-)

	Lol. And of course, it looks like nested foreaches on the same
collection would also break [ though it's not that likely to be
sure ;-]. I added to your clean by using a for(;;) loop to make it
clearer.

	Thanks,

		Michael.

-- 
 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot




More information about the LibreOffice mailing list