[Libreoffice] [PUSHED] Re: Bug #i89051

Jan Holesovsky kendy at suse.cz
Wed Nov 2 08:00:07 PDT 2011


Hi Ivan,

On 2011-11-01 at 17:12 +0400, Ivan Timofeev wrote:

> --Possible solutions.--
> 
> 1. Rearrange the following lines of the SetMarkHandles method
> (svx/source/svdraw/svdmrkv.cxx#805):
> 
>         // add custom handles (used by other apps, e.g. AnchorPos)
>         AddCustomHdl();
>         // sort handles
>         aHdl.Sort();
> 
> to:
> 
>         // sort handles
>         aHdl.Sort();
>         // add custom handles (used by other apps, e.g. AnchorPos)
>         AddCustomHdl();
> 
> 2. Tweak sorting of handles somehow - method Compare
> (svx/source/svdraw/svdhdl.cxx#1704) looks ugly...
> 3. Something else.
> 
> Can someone provide some comments/tips/decisions?

Very nice analysis!  According to what you described, the 1. (changing
the order) sounds great to me, and works nicely too :-) - so I have
pushed that, if you don't mind:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2ab818f8e9822ff027ad6c90e7b6fb1f4c089f9f

Regards,
Kendy



More information about the LibreOffice mailing list