[Libreoffice] [PUSHED] First Patch

[Emanuele Fia]

>git reset -hard HEAD~1 # warning this looses the head commit
>before running ./g pull -r to avoid conflicts (assuming you didn't do
>any more commits yet).

This is for reset my local repo and restore the current version on git
repository ?


>A thing that really helps us, is if you could send a mail to the list
>with a blanket license for your commits: of the form you can see linked
>into the developers wiki here:

Ok , where i can find infromation about  MPL/LGPLv3+ ?

(Sorry this is my first experience as developers)


>Anyhow ! the CurrencyBox stuff seems like it might be a good place to
>investigate if you want to do a bigger chunk of cleanup here; are you
>able to compile after changing things ?

I'm not sure i understand correcty...

(What's CurrencyBox ? )

Yes , i'm able to compile code and check if build fails after changes or not.

But how i can submit patch ? Send an email to this maillist and stop?
My last patch is "formatted" correctly?

Thanks

2011/11/3 Caolán McNamara <caolanm at redhat.com>:
> On Thu, 2011-11-03 at 11:39 +0000, Michael Meeks wrote:
>> On Wed, 2011-11-02 at 19:08 +0100, Emanuele Fia wrote:
>> > I have to remove also form unusedcode.easy the function removed ?
>>
>>       I imagine so; although Caolan is really the expert here. I tweaked your
>> patch a little, so as you may need to:
>
> Yeah, remove it from unusedcode.easy as well.
>
> I regenerate that list every now and then. But it's best to remove them
> from the list manually when you remove the unused code so that noone
> tries to remove an already removed method in the gap between
> regenerations of the list.
>
> I really really should add file:line numbers to the tooling
> (https://github.com/caolanm/callcatcher) I guess. Sometimes it can be
> hard to find them because some of the unused methods are generated from
> big macros.
>
> C.
>
>