[Libreoffice] [PUSHED][PATCH] Removed some SvStringsSortDtor

[Eike Rathke]

Hi Caolán,

On Tuesday, 2011-11-08 15:01:53 +0000, Caolán McNamara wrote:

> > Looking at htmlexp.cxx:1320, pSrcArr is used to lookup for an index of
> > a string, and then the index is applied to pDstArr.
> > In my understanding indices of two arrays are unrelated, because
> > arrays are sorted by their respective contents.
> 
> Yeah, it's puzzling. Original code doesn't look right at all.

Indeed.. probably didn't get noticed as the same graphic used more than
once in a sheet that is exported to HTML isn't such a common case..

> > I guess what is intended here is mapping of strings, from pSrcArr to
> > pDstArr (with incorrect implementation).
> 	
> The intent seems fairly clear anyway, so it looks like a std::map
> identifier->filename is what's wanted.

Correct.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111110/2b849f3a/attachment.pgp>