[Libreoffice] [PATCH] Re: Easy hack regex compile infinite loop ( bug 41738 )

Karl Koehler koehlerkarl at comcast.net
Thu Nov 10 21:44:33 PST 2011


Hi,

investigating further I have come to the conclusion that the attached
( and previously inlined ) patch is correct, in the sense that regular
expressions of the failing type are now handled correctly.

e.g.
 A[\[:\]]

should find an 'A' followed by one of '[',':',']' and it does now (old
behavior: infinite loop).

I don't seem to see any regression tests for reclass ?

Also, and independent of this issue, certain regular expressions don't
work as expected, e.g.
  A[\[:]
unexpectedly matches nothing, but
  A[:\[] 
and
  A[\[\:] 
do... ( as far as I know ':' should match itself unless one of the
special posix ranges is used. )

Review or comment would be greatly appreciated !
Thanks,

  - Karl

-------------- next part --------------
A non-text attachment was scrubbed...
Name: reclass.patch
Type: text/x-patch
Size: 294 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111110/4d1d74c5/attachment.bin>


More information about the LibreOffice mailing list