[Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage

Eike Rathke erack at redhat.com
Mon Nov 14 06:11:21 PST 2011


Hi Markus,

On Saturday, 2011-11-12 16:11:09 +0100, Markus Mohrhard wrote:

> This part might be worng:
> 
>          if ( bValue )
> -            aString.AssignAscii( "###" );
> -        aString.Erase( nLen );
> +            aString = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( "###" ));

It is. The "###" was only assigned if the value was numeric, textual
values were truncated instead. The change now omits the truncation.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111114/b6bb6c0d/attachment.pgp>


More information about the LibreOffice mailing list