[Libreoffice] [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

Cedric Bosdonnat cedric.bosdonnat.ooo at free.fr
Thu Nov 17 00:27:07 PST 2011


Hi Michael,

On Wed, 2011-11-16 at 16:20 +0100, Michael Stahl wrote:
> now i remember: this bug is exactly the one i fixed in OOo in CWS
> sw34bf04 (issue i102333).
> 
> the fix is not merged in libreoffice-3-4, but is in master
> (230fcf4a456636bb466f72834cd57238621d206d),
> but LO master still crashes while an Apache OOo 3.4 build does not crash...
> 
> i will investigate what went wrong there; Cedric, any idea what changes
> could have broken it again?

No, I have no idea what could have broken that again.

> i am currently not sure if your patch is the right fix; i would assume
> that the cursor that points to the removed node should have been moved
> away from it by ... something.

Well, Tomofumi's patch looks like on more safety check in that couldn't
harm. I'ld go for pushing his (second) patch.

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr



More information about the LibreOffice mailing list