[Libreoffice] [Patch] Unreachable code ?

[Muthu Subramanian K]

That code is inside the constructor.
and the constructor sets the variable pUndoSet to NULL right on the top.
So, the if would always fail! Unless I am missing something. Looks too
trivial to be true ;)

On 11/17/2011 09:48 PM, Michael Meeks wrote:
> Hi Muthu,
> 
> On Wed, 2011-11-16 at 17:34 +0530, Muthu Subramanian K wrote:
>> I have attached a trivial code removal with this mail.
>> I read the code, (since pUndoSet is set to null in the very constructor,
>> I guess this if() would never get executed), but, I could have missed
>> something here - hence the need for review.
> 
> 	Looks like that was explicitly added in:
> 
> commit 493855a92f443535abca8fed0f04ac7c4668a85d
> Author: Pascal Junck <pjunck at openoffice.org>
> Date:   Wed Nov 3 10:06:38 2004 +0000
> 
>     INTEGRATION: CWS aw019 (1.14.140); FILE MERGED
>     2004/09/28 15:53:27 aw 1.14.140.1: #i11190#
> 
> 	Are you certain it is not needed ? then again, an in-line delete rather
> than the if(){} etc. might be good.
> 
> 	ATB,
> 
> 		Michael.
>