[Libreoffice] Assertions and Logging

[Caolán McNamara]

On Fri, 2011-11-18 at 15:25 +0100, Stephan Bergmann wrote:

Alright, so we end up with
use assert if you want an assert
SAL_WARN if you want to warn about something odd, but which isn't
necessarily definitely wrong
SAL_INFO for verbose logging

Practical question though, is on windows where does the output go ?

Should we write off all the DBG_ASSERTs as hopeless to unwind and mass
convert them all to SAL_WARNs ?

How do we feel about code that does e.g.

assert(pFoo);
if (!pFoo)
    throw catchAbleFoo("wtf");

i.e. do we have a philosophical problem with gracefully/semi-gracefully
handing should-be impossible cases ?

C.