[Libreoffice] Solving an introduced runtime dependency on unreleased Qt version (KDE4 vcl backend)
Michael Meeks
michael.meeks at suse.com
Wed Nov 23 07:06:26 PST 2011
On Wed, 2011-11-23 at 15:32 +0100, Lubos Lunak wrote:
> It's at least not more broken than having one huge global mutex >:).
;-) not so convinced about that; but yes toolkit threading is quite a
fun problem.
> And the check seems to exist only in QPixmap and LO's Solar Mutex should
> ensure there's no other problem if this check is avoided. So that looks like
> this solves the problem, if people can fix their installed Qt library.
Great; so essentially removing that check prolly does it for us; but
your patch is fine too I guess.
> > before we start calling Qt methods each time. Hopefully that is
> > reasonably efficient (surely it's just a member variable).
>
> No, it is not and I expect moving QApplication instances between threads
> really wouldn't work.
Right, now I read that method it's something of a nightmare for this
use-case. So your fix seems to be all we can do.
Thanks,
Michael.
--
michael.meeks at suse.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice
mailing list