[Libreoffice] [PATCH] [PUSHED] Hide function pointers

Stephan Bergmann sbergman at redhat.com
Mon Nov 28 01:42:36 PST 2011


On 11/27/2011 08:57 AM, Daisuke Nishino wrote:
> Exposing functioin pointers to outside is not a good practice I think.
> This patch encapsulates them.
> Also, since fnLeaveSelect is called from only one location, I eliminated
> the indirection.

Great, thanks.  Pushed (I simplified the "this->*this->" calls by 
removing the redundant second "this->").

I do not find your license statement at 
<http://wiki.documentfoundation.org/Development/Developers>, can you add 
it there (I assume you contribute under LGPLv3+/MPL 1.1+)?

Thanks,
Stephan


More information about the LibreOffice mailing list