[Libreoffice] [PATCH] Removing uses of OUString::setCharAt

[August Sodora]

Thanks! I've attached another one that should leave only a few more
uses to clean up, mostly with macos-related code. I didn't push this
myself because I really wanted to make sure all the bounds checking is
correct.

August Sodora
augsod at gmail.com
(201) 280-8138



On Mon, Nov 28, 2011 at 12:30 PM, August Sodora <augsod at gmail.com> wrote:
>> looks good, pushed now - except for the svl/source/misc/lngmisc.cxx
>> snippet which was based on older code it seems, dropped that part
>> entirely.
>
> Yeah, sorry about that part. I decided it was worth it to write some
> tests for those functions and use that as the basis for cleaning it
> up.
>
> August Sodora
> augsod at gmail.com
> (201) 280-8138
>
>
>
> On Mon, Nov 28, 2011 at 9:01 AM, Thorsten Behrens
> <thb at documentfoundation.org> wrote:
>> August Sodora wrote:
>>> Tonight I tried to remove some uses of setCharAt so that it can
>>> eventually be removed, and I ran across a few cases that I would like
>>> to get another pair of eyes on. Especially in one particular case, I
>>> added a guard to make sure that the index was within range and I want
>>> to make sure that it is necessary or if something more involved is
>>> required. The patch is attached, and I remembered to add [PATCH] to
>>> the subject this time :)
>>>
>> Hi August,
>>
>> looks good, pushed now - except for the svl/source/misc/lngmisc.cxx
>> snippet which was based on older code it seems, dropped that part
>> entirely.
>>
>> Thanks a lot, looking forward for more! :)
>>
>> -- Thorsten
>>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-uses-of-charAt.patch
Type: text/x-patch
Size: 20809 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111128/f11f695b/attachment-0001.bin>