[Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

Pierre-André Jacquod pjacquod at alumni.ethz.ch
Tue Nov 29 10:39:09 PST 2011


Hello,
sorry, I was sure there was more about it...but too early this morning, 
I could not sort out all points.

> Now you also changed bOnlyDown=false to bOnlyDown=true, which leads to
> not include newly appended columns of an area. Why?
by the way, this reflect the comment in

void ScDBData::ExtendDataArea(ScDocument* pDoc)
{
     // Extend the DB area to include data rows immediately below.

which comment is from Kohei ( 9f9ff37f ) who toke this from a previous 
comment. Hence, the change would make the call be in line with the comment.

This is the original reason why I started to play with it and changed it 
like this, since comment and implementation were not coherent.

Regards
Pierre-André


More information about the LibreOffice mailing list